Wireshark-commits: [Wireshark-commits] master-3.0 ee4adc1: Fix the temporary file string buffer exp

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Oct 2019 22:20:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee4adc10af608c645f36a535ebdb15f59c61e5f1
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

ee4adc1 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the temporary file string buffer expansion.
    
    The buffer needs to be big enough to include the trailing '\0', so we
    need to compare the buffer's length against strlen(name) + 1, not
    against strlen(name).
    
    Bug: 15751
    Change-Id: I75ae65f8c818284834d761d9dd911d029cfca3b1
    Reviewed-on: https://code.wireshark.org/review/34892
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d0f8691d3ff9a0c7a93ccd66de915b58dbc906bc)
    Reviewed-on: https://code.wireshark.org/review/34893
    

Actions performed:

    from  b671c13   HomePlug AV: Fix dissection of MMTYPE and FMI
     add  ee4adc1   Fix the temporary file string buffer expansion.


Summary of changes:
 wsutil/tempfile.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)