Wireshark-commits: [Wireshark-commits] master 5459104: Fix the temporary file string buffer expansi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Oct 2019 22:20:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5459104358d385fa2c1b34dd228e5c47bf3bce2f
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5459104 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the temporary file string buffer expansion.
    
    The buffer needs to be big enough to include the trailing '\0', so we
    need to compare the buffer's length against strlen(name) + 1, not
    against strlen(name).
    
    Bug: 15751
    Change-Id: I75ae65f8c818284834d761d9dd911d029cfca3b1
    Reviewed-on: https://code.wireshark.org/review/34892
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7923943   SDP: Handle MCPTT fmtp parameter.
     add  5459104   Fix the temporary file string buffer expansion.


Summary of changes:
 wsutil/tempfile.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)