Wireshark-commits: [Wireshark-commits] master 307b296: SMB2: improved dissector of QUERY_INFO/SET_I

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 04 Oct 2019 04:40:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=307b2961497684139508ec30b744ecf2b5d9eb36
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

307b296 by Volodymyr Khomenko (volodymyr@xxxxxxxxxxxx):

    SMB2: improved dissector of QUERY_INFO/SET_INFO - AdditionalInformation field
    
    Changed dissection of AdditionalInformation field for QUERY_INFO/SET_INFO with SEC_INFO class
    to use all security information bits defined by [MS-SMB2]. See
    [MS-SMB2] 2.2.37 SMB2 QUERY_INFO Request and 2.2.39 SMB2 SET_INFO Request
    
    Changed dissection of SET_INFO to report Reserved/AdditionalInformation instead of unknown field.
    
    Bug: 16095
    Change-Id: I28373cba67385cfd9db173cbc0469e893704cd69
    Reviewed-on: https://code.wireshark.org/review/34659
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d2a660d   QUIC: Add Follow QUIC Stream support to Qt and tshark
     add  307b296   SMB2: improved dissector of QUERY_INFO/SET_INFO - AdditionalInformation field


Summary of changes:
 epan/dissectors/packet-smb2.c | 159 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 150 insertions(+), 9 deletions(-)