Wireshark-commits: [Wireshark-commits] master d2a660d: QUIC: Add Follow QUIC Stream support to Qt a

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 04 Oct 2019 04:36:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2a660d805df50a2cbf92dc9e75114d5c05b616d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d2a660d by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: Add Follow QUIC Stream support to Qt and tshark
    
    The QUIC transport protocol provides a stream, similar to HTTP/2. Make
    it possible to look at the stream contents. This can be helpful while
    HTTP/3 support is not yet complete.
    
    Known issues that will be addressed in the future:
    
     - If a single packet contains multiple streams, then Follow QUIC Stream
       will wrongly include data from streams other than the selected one.
       This is tracked by bug 16093 and affects HTTP/2 as well.
    
     - The Substream index menu does not properly filter for available
       stream numbers. If a non-existing stream is selected, then changing
       to another (potentially valid) index results in the "Capture file
       invalid." error. As workaround, clear the display filter first.
    
     - Follow Stream always selects Stream ID 0 instead of the first or
       currently selected stream field in a packet. Users should manually
       update the stream index as needed.
    
    Change-Id: I5866be380d58c96f0a71a29abdbd1be20ae3534a
    Ping-Bug: 13881
    Reviewed-on: https://code.wireshark.org/review/34694
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  750ffac   Win32: Fix a return value check.
     add  d2a660d   QUIC: Add Follow QUIC Stream support to Qt and tshark


Summary of changes:
 debian/libwireshark0.symbols                      |   1 +
 doc/tshark.pod                                    |   6 ++
 docbook/wsug_src/WSUG_chapter_advanced.adoc       |   3 +
 epan/dissectors/CMakeLists.txt                    |   1 +
 epan/dissectors/packet-quic.c                     | 101 +++++++++++++++++++++-
 wsutil/bitswap.h => epan/dissectors/packet-quic.h |  16 ++--
 epan/follow.h                                     |   3 +-
 ui/cli/tap-follow.c                               |   7 +-
 ui/qt/follow_stream_dialog.cpp                    |  45 +++++++++-
 ui/qt/main_window.h                               |   1 +
 ui/qt/main_window.ui                              |   9 ++
 ui/qt/main_window_slots.cpp                       |  10 ++-
 ui/qt/packet_list.cpp                             |   1 +
 ui/qt/proto_tree.cpp                              |   1 +
 14 files changed, 184 insertions(+), 21 deletions(-)
 copy wsutil/bitswap.h => epan/dissectors/packet-quic.h (58%)