Wireshark-commits: [Wireshark-commits] master ec10752: BSSMAP: Introduce Osmocom Osmux Support and

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Jun 2019 06:15:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec10752adb786fc3478a8dc04d091571c18100a3
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ec10752 by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    BSSMAP: Introduce Osmocom Osmux Support and CID extension IE
    
    References:
    https://git.osmocom.org/libosmocore/commit/?id=18506c850c3bbcbfa814e07dc02a17fdb5f7bb9a
    https://osmocom.org/issues/2551
    
    IE GSM0808_IE_OSMO_OSMUX_SUPPORT (T, 1 byte) is sent in AoIP appended to
    BSSMAP RESET in order to announce the peer that its MGW supports handling
    Osmux streams upon call set up.
    
    IE GSM0808_IE_OSMO_OSMUX_CID (TV, T 1 byte & V 1 byte) is sent in AoIP
    during call set up:
    * MSC->BSC Assignment Request
    * BSC->MSC Assignemnt Complete
    
    The 1 byte value contains the local Osmux CID, aka the recvCID aka CID where the
    peer sending the Assign Req/Compl will look for Osmux frames on that
    call. Hence, the peer receiving this CID value must use it to send Osmux
    frames for that call.
    
    As a result, a given call leg BSC<->MSC can have one different Osmux CID
    per direction. For example:
    * MS => MGW_BSC ==CID 0==> MGW_MSC
    * MS <= MGW_BSC <=CID 1=== MGW_MSC
    
    This allows for setups with 256 call legs per BSC on scenarios where NAT
    is not a problem, where MSC can have a pool of 256 CID per MGW_BSC (or
    remote peer).
    
    Change-Id: Idc7a59a112c1eade2a056bc93230d580f58dda80
    Reviewed-on: https://code.wireshark.org/review/33668
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  737b7eb   Qt: Handle ApplicationPaletteChange events in the welcome page.
     add  ec10752   BSSMAP: Introduce Osmocom Osmux Support and CID extension IE


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c | 209 +++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-gsm_a_common.h |  93 +++++++++++++++
 2 files changed, 301 insertions(+), 1 deletion(-)