Wireshark-commits: [Wireshark-commits] master 737b7eb: Qt: Handle ApplicationPaletteChange events i

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Jun 2019 06:14:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=737b7eb6c6e0c0b06d512ed093d3de94ef698f35
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

737b7eb by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Handle ApplicationPaletteChange events in the welcome page.
    
    Update our various welcome page style sheets when we receive an
    ApplicationPaletteChange event.
    
    It looks like ApplicationPaletteChange is the proper way to detect a
    system-wide theme change, since we can infinitely recurse if we hold
    things wrong inside a regular PaletteChange event (I'm guessing setting
    CSS background and foreground colors were the culprits in this case).
    Switch from PaletteChange to ApplicationPaletteChange everywhere.
    
    Ping-Bug: 15511
    Change-Id: I6e7aa627d9ca1d1d3872ab31620ea5c579061191
    Reviewed-on: https://code.wireshark.org/review/33703
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  a9ed943   Qt: Split the filter dropdown arrow icon into dark and light versions.
     add  737b7eb   Qt: Handle ApplicationPaletteChange events in the welcome page.


Summary of changes:
 ui/qt/main_window.cpp                       |   2 +-
 ui/qt/utils/stock_icon.cpp                  |   1 -
 ui/qt/welcome_page.cpp                      | 203 ++++++++++++++++------------
 ui/qt/welcome_page.h                        |   3 +
 ui/qt/widgets/filter_expression_toolbar.cpp |   2 +-
 ui/qt/widgets/stock_icon_tool_button.cpp    |   2 +-
 6 files changed, 121 insertions(+), 92 deletions(-)