URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1000f3f6d5b2b4b399eda5fb5d9e139c4577fb03
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
1000f3f by Guy Harris (guy@xxxxxxxxxxxx):
Don't assume dissect_smb2_olb_string() returned a non-null pointer.
It can return null on error; don't add the string it returned to the
Info column if it didn't return a string.
Fixes Coverity CID 1445960.
Change-Id: I73b1585e95e39ad998f10d2a017f33fb3d54e7a7
Reviewed-on: https://code.wireshark.org/review/33569
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 2def295 Eliminate more calls to get_unicode_or_ascii_string().
add 1000f3f Don't assume dissect_smb2_olb_string() returned a non-null pointer.
Summary of changes:
epan/dissectors/packet-smb2.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)