Wireshark-commits: [Wireshark-commits] master 2def295: Eliminate more calls to get_unicode_or_ascii

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Jun 2019 20:16:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2def295022a8ab6cc932e7f47096cdc80190547b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2def295 by Guy Harris (guy@xxxxxxxxxxxx):

    Eliminate more calls to get_unicode_or_ascii_string().
    
    Just use proto_tree_add_item() or tvb_get_string_enc(); that way, we
    handle full UTF-16, not just the ISO 8859/1 subset thereof.
    
    Change-Id: I8ded392b87522c45902354092d6988965265d3b3
    Reviewed-on: https://code.wireshark.org/review/33567
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  cbdfc13   Qt: Selected item preference updates.
     add  2def295   Eliminate more calls to get_unicode_or_ascii_string().


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 14 +----
 epan/dissectors/asn1/ldap/packet-ldap-template.c   | 46 ++++++++++-----
 epan/dissectors/packet-dcerpc-dnsserver.c          | 15 +----
 epan/dissectors/packet-dcerpc-witness.c            | 61 ++++++++++++++++----
 epan/dissectors/packet-kerberos.c                  | 26 +++------
 epan/dissectors/packet-ldap.c                      | 58 +++++++++++++------
 epan/dissectors/packet-ntlmssp.c                   | 30 ++++------
 epan/dissectors/packet-ntlmssp.h                   |  6 +-
 epan/dissectors/packet-rsvd.c                      | 13 +----
 epan/dissectors/pidl/dnsserver/dnsserver.cnf       | 16 +-----
 epan/dissectors/pidl/witness/witness.cnf           | 67 +++++++++++++++++-----
 11 files changed, 206 insertions(+), 146 deletions(-)