Wireshark-commits: [Wireshark-commits] master beed21b: Fix the length of the item added for the val

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 May 2019 18:21:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beed21b038683377efb7b5c13b36a3a35fa720a2
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

beed21b by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the length of the item added for the value field of undissected CLVs.
    
    The length variable is the length of the value, not the length of the
    entire CLV, so there's no need to subtract the length of the C and the
    L from the length - it covers just the V.
    
    Change-Id: I711657e4e0b76e2aac9d58efd88f45201b9c2c5b
    Reviewed-on: https://code.wireshark.org/review/33174
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c135fb1   K12: reverse use after free
     add  beed21b   Fix the length of the item added for the value field of undissected CLVs.


Summary of changes:
 epan/dissectors/packet-isis-clv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)