Wireshark-commits: [Wireshark-commits] master c135fb1: K12: reverse use after free

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 May 2019 15:01:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c135fb1308e5f467722ea7861114e0d0f445f947
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c135fb1 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    K12: reverse use after free
    
    When composing the error string to return to the UAT handling,
    the proto name string is already free'd. Reverse the two calls
    so that the string is free'd _after_ the error string composition.
    
    Change-Id: I11615c07f6b00e59007e0c85c84283d486cc478c
    Reviewed-on: https://code.wireshark.org/review/33167
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3e8d907   [Automatic update for 2019-05-12]
     add  c135fb1   K12: reverse use after free


Summary of changes:
 epan/dissectors/packet-k12.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)