URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d2b51410f3345ad263125647aeb5948b2143d77
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
8d2b514 by Michael Mann (mmann78@xxxxxxxxxxxx):
SMPP: General improvements
1. Use proto_tree_add_item (and friends) instead of a protocol specific
wrapper for integer types
2. Create #defines for command IDs and properly sort them in the their value_string
3. Improve heuristics for command specific parameters to reduce false positives
4. Use length value in TLV for strings
5. Remove "sub tvb" creation. The tvb passed into the pdu should be used.
6. Use proto_tree_add_bitmask_list and proto_tree_add_bitmask_list_value where applicable
7. Allow empty fields for vendor-specific TLVs.
8. Treat version fields as FT_UINT8 and use format with BASE_CUSTOM
9. Condense all command response codes to a single range_string.
Bug: 5206
Bug: 15267
Change-Id: I49751d287af1ebb9e27ae7463c08f4724ee60c07
Reviewed-on: https://code.wireshark.org/review/31267
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 36981a6 KNET: Validate the length field before claiming packet
add 8d2b514 SMPP: General improvements
Summary of changes:
epan/dissectors/packet-smpp.c | 1754 ++++++++++++++++++++---------------------
1 file changed, 841 insertions(+), 913 deletions(-)