Wireshark-commits: [Wireshark-commits] master 36981a6: KNET: Validate the length field before claim

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 31 Dec 2018 08:00:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36981a653ea60b55f62efea4f1cb07e42687dd37
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

36981a6 by Michael Mann (mmann78@xxxxxxxxxxxx):

    KNET: Validate the length field before claiming packet
    
    Heuristic is weak, but length of packet should be non-zero.
    
    Change-Id: I68d6d85092c84d5d421731be3ada008fe7a5b06f
    Reviewed-on: https://code.wireshark.org/review/31266
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  080ff63   GSM over IP: Require a valid message type for dissection.
     add  36981a6   KNET: Validate the length field before claiming packet


Summary of changes:
 epan/dissectors/packet-knet.c | 8 ++++++++
 1 file changed, 8 insertions(+)