Wireshark-commits: [Wireshark-commits] master-2.6 926f98f: isobus-vt: fix issue found by PVS Studio

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Dec 2018 07:17:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=926f98f05ec53686423612c0ee4886fc3ccf4cb4
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

926f98f by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    isobus-vt: fix issue found by PVS Studio (V523)
    
    The 'then' statement is equivalent to the 'else' statement.
    
    Change-Id: I49c50208933c00be8bc16b5b8de15ab85e8094f5
    Reviewed-on: https://code.wireshark.org/review/27601
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 7754c3086b30c61a05485e422ae320ab5afc055a)
    Reviewed-on: https://code.wireshark.org/review/31111
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  07c349a   Don't free something before freeing some of its contents.
     add  926f98f   isobus-vt: fix issue found by PVS Studio (V523)


Summary of changes:
 epan/dissectors/packet-isobus-vt.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)