Wireshark-commits: [Wireshark-commits] master-2.4 dcab121: Don't free something before freeing some

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Dec 2018 07:14:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dcab121f39f853a033df3510d93f2560c158a743
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

dcab121 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't free something before freeing some of its contents.
    
    Free the wspstat_t only after freeing the hash table contained in it.
    
    Change-Id: I2aa31d74b6d0f86e5404a9b614fee8a3f6708938
    Ping-Bug: 15365
    Reviewed-on: https://code.wireshark.org/review/31108
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0fc7f3781351c23cf05bdaafc1dd3dc6f9a08a2c)
    Reviewed-on: https://code.wireshark.org/review/31110
    

Actions performed:

    from  b3f7c40   Clean up exp_pdu_open() API.
     add  dcab121   Don't free something before freeing some of its contents.


Summary of changes:
 ui/cli/tap-wspstat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)