Wireshark-commits: [Wireshark-commits] master-2.6 14e07e0: Treat the strings for simple dialogs as

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Dec 2018 09:49:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14e07e0678b8d26df6903819194d62cc041a0a68
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

14e07e0 by Guy Harris (guy@xxxxxxxxxxxx):

    Treat the strings for simple dialogs as UTF-8 on Windows.
    
    On Windows, filename strings inside Wireshark are UTF-8 strings, so
    error messages containing file names are UTF-8 strings.  Convert from
    UTF-8, not from the local code page.
    
    Bug: 15367
    Change-Id: I52f3de2606ec6a592e7cb82b1a9aaeeef8acecef
    Reviewed-on: https://code.wireshark.org/review/31090
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 18b87c7ad2ab5a77c709bc43e53369c5b36561c2)
    Reviewed-on: https://code.wireshark.org/review/31091
    

Actions performed:

    from  729a0b7   Add routines to load Lua programs that assume the path is UTF-8 on Windows.
     add  14e07e0   Treat the strings for simple dialogs as UTF-8 on Windows.


Summary of changes:
 ui/qt/simple_dialog.cpp | 12 ++++++++++++
 1 file changed, 12 insertions(+)