Wireshark-commits: [Wireshark-commits] master ae83101: Treat the strings for simple dialogs as UTF-

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Dec 2018 09:49:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae83101dd5643c3852ca67ffb331cd8dbd20c727
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ae83101 by Guy Harris (guy@xxxxxxxxxxxx):

    Treat the strings for simple dialogs as UTF-8 on Windows.
    
    On Windows, filename strings inside Wireshark are UTF-8 strings, so
    error messages containing file names are UTF-8 strings.  Convert from
    UTF-8, not from the local code page.
    
    Bug: 15367
    Change-Id: I52f3de2606ec6a592e7cb82b1a9aaeeef8acecef
    Reviewed-on: https://code.wireshark.org/review/31090
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c0a2844   Provide data to inner dissector for PER open type
     add  ae83101   Treat the strings for simple dialogs as UTF-8 on Windows.


Summary of changes:
 ui/qt/simple_dialog.cpp | 12 ++++++++++++
 1 file changed, 12 insertions(+)