Wireshark-commits: [Wireshark-commits] master df4294b: gsmtap: Fix parsing of FPC field

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2018 11:10:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df4294ba583e26c534741e05b5c44a3bd616e8cd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

df4294b by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    gsmtap: Fix parsing of FPC field
    
    Issue was spotted because the bit used by wireshark in this field
    didn't make sense, as same bit was being used by MS Power field.
    
    According to spec "3GPP TS 44.004" section "7.2 SACCH uplink block format",
    the field is located in bit 6 of the 1st octet.
    
    Change-Id: Ia4390b79d9d2b3966c4ca69eda0bf1ae10be7398
    Reviewed-on: https://code.wireshark.org/review/29893
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ac5fec7   http2: fix build without nghttp2
     add  df4294b   gsmtap: Fix parsing of FPC field


Summary of changes:
 epan/dissectors/packet-gsmtap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)