Wireshark-commits: [Wireshark-commits] master ac5fec7: http2: fix build without nghttp2

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2018 04:36:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac5fec75f804fca6030b3e2648345f7f0f21ba7e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ac5fec7 by Peter Wu (peter@xxxxxxxxxxxxx):

    http2: fix build without nghttp2
    
    current_stream_id is only defined when built with HAVE_NGHTTP2. One
    option is to create the session with stream ID unconditionally. As the
    subdissector (DoH) is chosen based on the Content-Type header and
    parsing of such headers is only possible with nghttp2, don't bother.
    
    Change-Id: Iefee65210974bf5b8b75c6870a0476567b6830e5
    Fixes: v2.9.0rc0-2007-gcc69e09981 ("HTTP2: allow subdissectors to query the Stream ID")
    Reviewed-on: https://code.wireshark.org/review/29896
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ce03200   sharkd: remove compiler warning.
     add  ac5fec7   http2: fix build without nghttp2


Summary of changes:
 epan/dissectors/packet-http2.c | 8 ++++++++
 1 file changed, 8 insertions(+)