Wireshark-commits: [Wireshark-commits] master 47b1ec9: Fix WITHOUT_VALS.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Sep 2018 02:07:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47b1ec984bc114b30c3bc144f48cd9b4c477e8c5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

47b1ec9 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix WITHOUT_VALS.
    
    It was setting EF_TYPE and then clearing it; it should set EF_TYPE and
    clear EF_VALS.
    
    Change-Id: Ie0a85a12646c0395e50abb34caf32367e4191da0
    Reviewed-on: https://code.wireshark.org/review/29621
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  69a01b6   With llvm-gcc, just don't do -Wshorten-64-to-32.
     add  47b1ec9   Fix WITHOUT_VALS.


Summary of changes:
 tools/asn2wrs.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)