Wireshark-commits: [Wireshark-commits] master 69a01b6: With llvm-gcc, just don't do -Wshorten-64-to

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Sep 2018 01:29:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69a01b650ac6c48b46d72838188ec1a5ffc40765
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

69a01b6 by Guy Harris (guy@xxxxxxxxxxxx):

    With llvm-gcc, just don't do -Wshorten-64-to-32.
    
    If you specify -Werror and -Wshorten-64-to-32, there does not appear to
    be any way to get llvm-gcc *NOT* to treat those warnings as errors - not
    with pragmas, and not even with -Wno-error=shorten-64-to-32.
    
    Change-Id: Ia82df3f548085cca8d187c4b43c02060b87f0542
    Reviewed-on: https://code.wireshark.org/review/29620
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2f65fba   -Wcomma isn't supported by llvm-gcc, so don't make it a non-error.
     add  69a01b6   With llvm-gcc, just don't do -Wshorten-64-to-32.


Summary of changes:
 CMakeLists.txt | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)