Wireshark-commits: [Wireshark-commits] master 4207660: Revert "Make versions of DIAG_OFF() and DIAG

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Sep 2018 18:54:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=420766099630d0fdcf403e93f5cfffc52889f7ce
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4207660 by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5."
    
    This reverts commit f6b8bc39c66c878ff25a4f48fff382f8775a2711.
    
    Reason for revert: prior to 4.6 or so, the pragmas didn't work as well,
    e.g. they couldn't be used inside a function; we depend on them being
    usable within a function.
    
    Change-Id: I7a7a0c08a2aca553233c237b8b6c43115095804e
    Reviewed-on: https://code.wireshark.org/review/29610
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b768582   Don't use -Werror with llvm-gcc.
     add  4207660   Revert "Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5."


Summary of changes:
 ws_diag_control.h | 86 +++++++++----------------------------------------------
 1 file changed, 14 insertions(+), 72 deletions(-)