Wireshark-commits: [Wireshark-commits] master b768582: Don't use -Werror with llvm-gcc.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Sep 2018 18:36:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7685821c10f37009cebe22810c2fdd63b05cd32
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b768582 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use -Werror with llvm-gcc.
    
    Apple's llvm-gcc appears not to support suppressing warnings with
    pragmas, so, if we're building on a Mac (we check for APPLE), and we're
    not using Clang, we don't turn on -Werror, because we rely on those
    pragmas to suppress otherwise-unremovable warnings in order to build
    warning-free.
    
    Change-Id: I43bd1ab42918c6ba22643b4a2d4cc3618c25434b
    Reviewed-on: https://code.wireshark.org/review/29609
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  342f7d2   ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
     add  b768582   Don't use -Werror with llvm-gcc.


Summary of changes:
 CMakeLists.txt | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)