Wireshark-commits: [Wireshark-commits] master-2.2 da53a90: DOF: fix an infinite loop in sid_buffer_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 5 Mar 2017 11:17:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da53a90b6895e47e03c5de05edf84bd99d535fd8
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

da53a90 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    DOF: fix an infinite loop in sid_buffer_hash_fn()
    
    The sid buffer can contain up to 255 bytes of data, so the loop counter must
    be a guint16 at least.
    
    Bug: 13453
    Change-Id: I997ce1a737532d94796586d7e109d89b2dc1911b
    Reviewed-on: https://code.wireshark.org/review/20388
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit c3dde590d8226bdb19149013acf9d45781adbd16)
    Reviewed-on: https://code.wireshark.org/review/20390
    

Actions performed:

    from  8f2e7b2   Fix the calculation of the number of levels in the radix tree.
    adds  da53a90   DOF: fix an infinite loop in sid_buffer_hash_fn()


Summary of changes:
 epan/dissectors/packet-dof.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)