Wireshark-commits: [Wireshark-commits] master c3dde59: DOF: fix an infinite loop in sid_buffer_hash

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 5 Mar 2017 11:16:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3dde590d8226bdb19149013acf9d45781adbd16
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c3dde59 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    DOF: fix an infinite loop in sid_buffer_hash_fn()
    
    The sid buffer can contain up to 255 bytes of data, so the loop counter must
    be a guint16 at least.
    
    Bug: 13453
    Change-Id: I997ce1a737532d94796586d7e109d89b2dc1911b
    Reviewed-on: https://code.wireshark.org/review/20388
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  e23676c   wmem: Ensure callbacks are initialized and not accidentally unregistered
    adds  c3dde59   DOF: fix an infinite loop in sid_buffer_hash_fn()


Summary of changes:
 epan/dissectors/packet-dof.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)