Wireshark-commits: [Wireshark-commits] master 799827b: Qt: Add Goodput graph (ACK rate), and minor

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Jan 2017 14:42:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=799827b503a61d1b7c0306f2c987e42e7280b0a3
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

799827b by Kevin Hogan (kwabena@xxxxxxxxxx):

    Qt: Add Goodput graph (ACK rate), and minor bug fixes
    
    Add Goodput graph:
     - measures rate of ACKed bytes (including SACKed bytes)
     - useful to compare to throughput during slow-start to estimate
         bottleneck rate
    
    Add graph selection checkboxes to multi-plot graphs:
     - most important for Throughput, since there are good cases
         for showing a subset of graphs at once
     - also added for Window Scale, since the addition is similar
         to that for Throughput
    
    Minor bug fixes:
     - allow zoom rect to work when growing in any direction
         (not just right and up)
     - keep stray mouse clicks from re-doing a previous zoom
     - hide rubber band if active when keypress changes mouse mode
         to drag
     - allow mouse clicks on open space or grpah to return to default focus
         (i.e. focus on graph)
    
    Change-Id: Id29356ceec810ebdbed9c3c0d8415416401fe643
    Reviewed-on: https://code.wireshark.org/review/19718
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  21a3b8c   Internalize struct preference
    adds  799827b   Qt: Add Goodput graph (ACK rate), and minor bug fixes


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp |  542 ++++++++++++++++++++++++++++++++++++++-----
 ui/qt/tcp_stream_dialog.h   |    7 +
 ui/qt/tcp_stream_dialog.ui  |   95 +++++++-
 ui/tap-tcp-stream.h         |    6 +-
 4 files changed, 592 insertions(+), 58 deletions(-)