Wireshark-commits: [Wireshark-commits] master 21a3b8c: Internalize struct preference

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Jan 2017 10:44:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21a3b8cc71ac127e21375c62e0a738db8f3ea286
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

21a3b8c by Michael Mann (mmann78@xxxxxxxxxxxx):

    Internalize struct preference
    
    Move "struct preference" into prefs.c, essentially creating a "private"
    structure to handle preferences. The 2 motivating factors were:
    1. Better memory management so that clients/users of API don't have to worry
    about it.
    2. Hide the ugliness of the union stuff and make it transparent to the API.
    
    A few bugs related to preference <-> Decode As integration were fixed
    while in the neighborhood.
    
    Change-Id: I509b9a236235d066b139c98222b701475e0ed365
    Reviewed-on: https://code.wireshark.org/review/19578
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  76cf1d0   Qt: Implement Custom CMake
    adds  21a3b8c   Internalize struct preference


Summary of changes:
 debian/libwireshark0.symbols             |   31 +-
 epan/decode_as.c                         |   38 +-
 epan/dissectors/packet-megaco.c          |    2 +-
 epan/prefs-int.h                         |  117 +++----
 epan/prefs.c                             |  557 +++++++++++++++++++++++++++---
 epan/show_exception.c                    |    2 +-
 extcap.c                                 |    1 -
 ui/gtk/airpcap_gui_utils.c               |   26 +-
 ui/gtk/decode_as_dlg.c                   |   53 ++-
 ui/gtk/main_menubar.c                    |   99 ++----
 ui/gtk/prefs_dlg.c                       |  228 +++++-------
 ui/preference_utils.c                    |   12 +-
 ui/qt/capture_preferences_frame.cpp      |   23 +-
 ui/qt/decode_as_dialog.cpp               |   46 +--
 ui/qt/extcap_argument.cpp                |    2 +-
 ui/qt/font_color_preferences_frame.cpp   |   64 ++--
 ui/qt/layout_preferences_frame.cpp       |   58 ++--
 ui/qt/main_window_preferences_frame.cpp  |   52 ++-
 ui/qt/module_preferences_scroll_area.cpp |   87 ++---
 ui/qt/preference_editor_frame.cpp        |   33 +-
 ui/qt/preferences_dialog.cpp             |   82 ++---
 ui/qt/protocol_preferences_menu.cpp      |   28 +-
 ui/qt/sctp_chunk_statistics_dialog.cpp   |   12 +-
 23 files changed, 992 insertions(+), 661 deletions(-)