Wireshark-commits: [Wireshark-commits] master-2.2 2f6c449: On Windows, put the standard output in b

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Nov 2016 18:40:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f6c44911aedbeac51f1d305a07376d1f10cb4bb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2f6c449 by Guy Harris (guy@xxxxxxxxxxxx):

    On Windows, put the standard output in binary mode if we're writing the capture file to it.
    
    While we're at it, explicitly compare the restult of strcmp() against 0,
    to make it clearer that it's testing for the argument *not* being equal
    to "-".
    
    Bug: 13165
    Change-Id: Ic63085abb2de5f5c60d2101d19c1a269b7e0c9d7
    Reviewed-on: https://code.wireshark.org/review/18924
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f4d6c7abbc32c5eee10e4f771f5e7fc1cc2639ef)
    Reviewed-on: https://code.wireshark.org/review/18925
    

Actions performed:

    from  bf964ff   RLC: always initialize LI length, even when it is malformed
    adds  2f6c449   On Windows, put the standard output in binary mode if we're writing the capture file to it.


Summary of changes:
 text2pcap.c |   15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)