Wireshark-commits: [Wireshark-commits] master f4d6c7a: On Windows, put the standard output in binar

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Nov 2016 18:40:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4d6c7abbc32c5eee10e4f771f5e7fc1cc2639ef
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f4d6c7a by Guy Harris (guy@xxxxxxxxxxxx):

    On Windows, put the standard output in binary mode if we're writing the capture file to it.
    
    While we're at it, explicitly compare the restult of strcmp() against 0,
    to make it clearer that it's testing for the argument *not* being equal
    to "-".
    
    Bug: 13165
    Change-Id: Ic63085abb2de5f5c60d2101d19c1a269b7e0c9d7
    Reviewed-on: https://code.wireshark.org/review/18924
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fb9a356   Add prefs_get_uint_value and prefs_get_range_value
    adds  f4d6c7a   On Windows, put the standard output in binary mode if we're writing the capture file to it.


Summary of changes:
 text2pcap.c |   15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)