Wireshark-commits: [Wireshark-commits] master-2.0 75ceda8: Fix some of the brokenness in the PRP re

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Jun 2016 09:34:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75ceda8706a6e38b3c9568c3c4ee77b8ee6ea906
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

75ceda8 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some of the brokenness in the PRP redundancy control trailer dissector.
    
    IF YOU ARE DOING A HEURISTIC CHECK TO DETERMINE WHETHER THE PACKET
    YOU'RE LOOKING AT IS ONE YOU SHOULD DISSECT, EVEN IN A DISSECTOR
    THAT'S NOT REGISTERED AS A HEURISTIC DISSECTOR, DO NOT LOOK AT PACKET
    BYTES UNLESS YOU HAVE ALREADY DETERMINED THAT THEY ARE AVAILABLE IN THE
    CAPTURE.
    
    THERE ARE NO EXCEPTIONS TO THIS RULE.
    
    Bug: 9826
    Change-Id: I2327a92ee760003bc10489263c0c53acdf2094e9
    Reviewed-on: https://code.wireshark.org/review/16092
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit a51b6a60b18a3fc81738533a84a72cd0b639ce5e)
    Reviewed-on: https://code.wireshark.org/review/16093
    

Actions performed:

    from  7a711e5   Qt: Fix crash in Conversations and Endpoints dialogs
    adds  75ceda8   Fix some of the brokenness in the PRP redundancy control trailer dissector.


Summary of changes:
 epan/dissectors/packet-prp.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)