Wireshark-commits: [Wireshark-commits] master a51b6a6: Fix some of the brokenness in the PRP redund

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Jun 2016 09:34:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a51b6a60b18a3fc81738533a84a72cd0b639ce5e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a51b6a6 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some of the brokenness in the PRP redundancy control trailer dissector.
    
    IF YOU ARE DOING A HEURISTIC CHECK TO DETERMINE WHETHER THE PACKET
    YOU'RE LOOKING AT IS ONE YOU SHOULD DISSECT, EVEN IN A DISSECTOR
    THAT'S NOT REGISTERED AS A HEURISTIC DISSECTOR, DO NOT LOOK AT PACKET
    BYTES UNLESS YOU HAVE ALREADY DETERMINED THAT THEY ARE AVAILABLE IN THE
    CAPTURE.
    
    THERE ARE NO EXCEPTIONS TO THIS RULE.
    
    Bug: 9826
    Change-Id: I2327a92ee760003bc10489263c0c53acdf2094e9
    Reviewed-on: https://code.wireshark.org/review/16092
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6b0923a   No pcap, no live capture, so no auto_scroll_live.
    adds  a51b6a6   Fix some of the brokenness in the PRP redundancy control trailer dissector.


Summary of changes:
 epan/dissectors/packet-prp.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)