URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8899e006aab3e0831214d187596eef450b5e21b7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
8899e00 by Peter Wu (peter@xxxxxxxxxxxxx):
Fix memleaks related to get_dirname
get_dirname may return NULL instead of the original string, so avoid
patterns like get_dirname(strdup(x)). Writing to
cf_path.toUtf8().data() is fine btw, toUtf8() returns new memory.
This fixes two memleak reported by LeakSanitizer via fileset_add_dir and
MainWindow::captureFileReadFinished (both via cf_callback_invoke).
Change-Id: I0f1528763e77e1f55b54b6674c890a9d02302ee8
Reviewed-on: https://code.wireshark.org/review/13691
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 36cf75e CIP/ENIP: Enhance Info column display
adds 8899e00 Fix memleaks related to get_dirname
Summary of changes:
fileset.c | 4 ++--
ui/gtk/main.c | 12 ++++++------
ui/qt/main_window.cpp | 8 ++++----
ui/qt/main_window_slots.cpp | 6 +++---
wireshark-qt.cpp | 4 ++--
5 files changed, 17 insertions(+), 17 deletions(-)