URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36cf75efb15827c801c4e82c8ab3ed16f3e00749
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
36cf75e by D. Ulis (daulis0@xxxxxxxxx):
CIP/ENIP: Enhance Info column display
1. ENIP: When there is more than one ENIP command in a given TCP packet, display both in the Info column. Previously, only 1 would be displayed.
2. CIP: Services need a context to be able to interpret properly. Display the Class or Symbol name in the Info column in an object oriented manner for Request Paths, or Connection Paths.
3. CIP: Display the request path/service in a CIP response, instead of just "Success". These changes make it visually easier to identify traffic.
4. CIP: For the Info column, make Multiple Service Packet formatting a little more consistent regarding the divider between embedded packets. Previously, it would display 2 different separator types "," and "|".
5. CIP: Add preference to enable/disable "Display enhanced Info column data"
Change-Id: I7e95bc144588c0925137e01abbc814babb494d19
Reviewed-on: https://code.wireshark.org/review/13632
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 6991149 [airpdcap] Add support to decrypt TDLS traffic
adds 36cf75e CIP/ENIP: Enhance Info column display
Summary of changes:
epan/dissectors/packet-cip.c | 139 +++++++++++++++++++++++++-----------
epan/dissectors/packet-cip.h | 10 ++-
epan/dissectors/packet-cipsafety.c | 4 +-
epan/dissectors/packet-enip.c | 4 +-
4 files changed, 111 insertions(+), 46 deletions(-)