Wireshark-commits: [Wireshark-commits] master-1.10 0adb6ee: A UAT's update is expected to set *erro

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 23:02:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0adb6ee4f35ed1039109d5538c73451c9b6b042b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

0adb6ee by Guy Harris (guy@xxxxxxxxxxxx):

    A UAT's update is expected to set *error; do so.
    
    Its callers treat a non-null error pointer as a failure and a null error
    pointer as a success, so it has to set *error, even if it's only setting
    it to NULL.
    
    Change-Id: Iae8cc2c4fba9fb680122a0ea820f3d8aad7c2ec3
    Reviewed-on: https://code.wireshark.org/review/7214
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  29de16d   Fix duplicate Display Filter Macro check
    adds  0adb6ee   A UAT's update is expected to set *error; do so.


Summary of changes:
 epan/dfilter/dfilter-macro.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)