Wireshark-commits: [Wireshark-commits] master-1.12 80653ca: A UAT's update is expected to set *erro

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 23:00:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80653cae89cc8d88cbd31408d27165e2d4a216e7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

80653ca by Guy Harris (guy@xxxxxxxxxxxx):

    A UAT's update is expected to set *error; do so.
    
    Its callers treat a non-null error pointer as a failure and a null error
    pointer as a success, so it has to set *error, even if it's only setting
    it to NULL.
    
    Change-Id: I52d671b0dbc0737cd856339f6ccafddd4ab320aa
    Reviewed-on: https://code.wireshark.org/review/7213
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  309a847   Fix duplicate Display Filter Macro check
    adds  80653ca   A UAT's update is expected to set *error; do so.


Summary of changes:
 epan/dfilter/dfilter-macro.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)