Wireshark-commits: [Wireshark-commits] master ca534b1: MIP6: Local Mobility Anchor Address mobility

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Feb 2015 16:41:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca534b1561c70f7d882d9d00bacf242a23346365
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ca534b1 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MIP6: Local Mobility Anchor Address mobility option code is treated incorrectly
    
    The first packet is an IPv6 packet with Local Mobility Anchor Address mobility option with Option-Code=1. Wireshark parses its address as IPv4 address.
    
    The second packet is an IPv6 packet with Local Mobility Anchor Address mobility option with Option-Code=2. Wireshark parses its address as IPv6 address.
    
    According to RFC 5949 (https://tools.ietf.org/html/rfc5949#section-6.2.2), Option-Code=1 means IPv6 and Option-Code=2 means IPv4, exactly the opposite to what Wireshark does.
    
    Bug: 10961
    Change-Id: I03b76dda8beae211e67e6c9e1f40d122e851b1b5
    Reviewed-on: https://code.wireshark.org/review/7113
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  847f590   MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly
    adds  ca534b1   MIP6: Local Mobility Anchor Address mobility option code is treated incorrectly


Summary of changes:
 epan/dissectors/packet-mip6.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)