Wireshark-commits: [Wireshark-commits] master-1.10 bb3ce2e: MIP6: AUTH mobility option parses Mobil

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Feb 2015 16:37:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb3ce2e71325cc4e90d3e6a1a7971a964ec52a93
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

bb3ce2e by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly
    
    The authentication data in the AUTH option in attached IPv6 packet contains one byte too much. This byte is read beyond the option data.
    In Wireshark, clicking on the AUTH shows that the option ends at 0xCE while clicking on the Authentication Data shows that it ends at 0xCF.
    
    Reported by Boaz
    
    Bug:10626
    Change-Id: I0bcfd6331bc1de30f25d16590487c0e3bf5c002f
    Reviewed-on: https://code.wireshark.org/review/7112
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 847f59096304a7aeebf7e9c498986cb05b960540)
    Reviewed-on: https://code.wireshark.org/review/7114
    (cherry picked from commit 02779202cd38c879e367e090321aeeb0d49ac994)
    Reviewed-on: https://code.wireshark.org/review/7115
    

Actions performed:

    from  bb9bd6b   Gryphon: do not use col_set_str with non constant strings
    adds  bb3ce2e   MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly


Summary of changes:
 epan/dissectors/packet-mip6.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)