Wireshark-commits: [Wireshark-commits] master 55646c8: Always check some -f flags.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2014 22:46:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55646c8427bbb2bef7903a181c6272da642eb2c4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

55646c8 by Guy Harris (guy@xxxxxxxxxxxx):

    Always check some -f flags.
    
    Now that we check each flag with all previously-accepted flags, this
    catches the case where -fwrapv causes -fno-strict-overflow to produce a
    warning when tested.
    
    This way, what we do matches what the autotools do.
    
    Change-Id: I68ce281dc33a32b591e3137db626f2749c4a0708
    Reviewed-on: https://code.wireshark.org/review/3370
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e2969cb   When testing compiler flags, test them with previously-tested flags.
    adds  55646c8   Always check some -f flags.


Summary of changes:
 CMakeLists.txt |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)