Wireshark-commits: [Wireshark-commits] master e2969cb: When testing compiler flags, test them with

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2014 22:44:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2969cbb3cc533ad0214e3d2d86d9543930c1528
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e2969cb by Guy Harris (guy@xxxxxxxxxxxx):

    When testing compiler flags, test them with previously-tested flags.
    
    That mirrors what we're doing with autotools, and catches cases where
    an earlier-tested flag affects the results for a later-tested flag
    (e.g., -fwrapv can affect whether -fno-strict-overflow produces a
    warning when tested).
    
    Change-Id: I8ca0b6f5dee14d2394af9b6b8b93b9dbda2702d7
    Reviewed-on: https://code.wireshark.org/review/3369
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  81f5d71   Get rid of trailing blank line.
    adds  e2969cb   When testing compiler flags, test them with previously-tested flags.


Summary of changes:
 CMakeLists.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)