Wireshark-commits: [Wireshark-commits] master 08a318a: Those address_to_str() calls were in packet

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 19:05:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08a318a4dfb6c2f907c15c3574ef547403d1dec5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

08a318a by Guy Harris (guy@xxxxxxxxxxxx):

    Those address_to_str() calls were in packet scope, and were safe.
    
    Change-Id: Ic727eca800a1b8972cf1a09cf2cf4ef8cfe4d0ba
    Reviewed-on: https://code.wireshark.org/review/2439
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  46ecf18   Use address_to_str(NULL, ...) for strings allocated outside dissectors.
    adds  08a318a   Those address_to_str() calls were in packet scope, and were safe.


Summary of changes:
 epan/dissectors/packet-hpteam.c |    2 +-
 epan/dissectors/packet-rtcp.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)