URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46ecf18fbdb6f02b1748ca72bd5e6ecf0e6c0886
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
46ecf18 by Guy Harris (guy@xxxxxxxxxxxx):
Use address_to_str(NULL, ...) for strings allocated outside dissectors.
ep_address_to_str() doesn't crash if called outside packet scope, but
it's still not correct to use outside packet scope. Use
address_to_str(NULL, ...) to allocate those strings, and then explicitly
free them when we're done; exceptions don't get thrown between the
allocate and free, so there's no risk of a leak.
Change-Id: Iea2af93b0757e648d399e2ba64249224eb7e9e3c
Reviewed-on: https://code.wireshark.org/review/2438
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 83762f9 Add sys/socket.h which should fix solaris
adds 46ecf18 Use address_to_str(NULL, ...) for strings allocated outside dissectors.
Summary of changes:
epan/dissectors/packet-bacapp.c | 40 ++++++++++++++++++++++++++++--------
epan/dissectors/packet-http.c | 8 ++++++--
epan/dissectors/packet-iax2.c | 20 +++++++++++++-----
epan/dissectors/packet-isup.c | 10 +++++++--
epan/dissectors/packet-ssl-utils.c | 15 +++++++++++---
epan/dissectors/packet-tacacs.c | 12 +++++++----
6 files changed, 81 insertions(+), 24 deletions(-)