Wireshark-commits: [Wireshark-commits] master-1.12 7e44111: Fix fencepost error in HTTP dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 May 2014 23:16:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e441119cb374490a7ad5613cf0d43a5af15ec42
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

7e44111 by Evan Huus (eapache@xxxxxxxxx):

    Fix fencepost error in HTTP dissector
    
    Strndup adds +1 for the null-terminator itself, no need to do it in the caller.
    This was causing us to go past the end of the buffer when the HTTP header line
    didn't have any spaces in it. Caught by Alexis using ASAN.
    
    Bug:10135
    Change-Id: Iee1b26da4740b774581ca6ec784ee40f7b920832
    Reviewed-on: https://code.wireshark.org/review/1807
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  8da17d1   Replace manual string handling with strbuf
    adds  7e44111   Fix fencepost error in HTTP dissector


Summary of changes:
 epan/dissectors/packet-http.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)