Wireshark-commits: [Wireshark-commits] master abed02a: Fix fencepost error in HTTP dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 May 2014 23:15:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abed02a8f7e946ba9cf4daaa509e14082209e463
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

abed02a by Evan Huus (eapache@xxxxxxxxx):

    Fix fencepost error in HTTP dissector
    
    Strndup adds +1 for the null-terminator itself, no need to do it in the caller.
    This was causing us to go past the end of the buffer when the HTTP header line
    didn't have any spaces in it. Caught by Alexis using ASAN.
    
    Bug:10135
    Change-Id: Iee1b26da4740b774581ca6ec784ee40f7b920832
    Reviewed-on: https://code.wireshark.org/review/1806
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  5dfdd2b   Optimize dissect_eth_common(): cache result of get_ether_name()
    adds  abed02a   Fix fencepost error in HTTP dissector


Summary of changes:
 epan/dissectors/packet-http.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)