Wireshark-commits: [Wireshark-commits] master 2e16091: Don't pass the address of a pointer to a *_s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 21:34:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e16091845811498d088c5ac0e3c94f21c5e58f1
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2e16091 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't pass the address of a pointer to a *_string to VALS() or RVALS().
    
    This is a followup to Ifc8d6895cc33ad1f00386a3e59926322bd501125; the MQ sample
    captures I have don't seg-fault on this but the code was stillw wrong.
    
    Change-Id: Ic689c06836b823a15217281d67b33580fd8e9823
    Reviewed-on: https://code.wireshark.org/review/1539
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  ec5ba07   Tweak ber_choice flow control.
    adds  2e16091   Don't pass the address of a pointer to a *_string to VALS() or RVALS().


Summary of changes:
 epan/dissectors/packet-mq-pcf.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)