Wireshark-commits: [Wireshark-commits] master ec5ba07: Tweak ber_choice flow control.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 20:32:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec5ba0795aba38a3740c67e3d6d370e66ce9e916
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ec5ba07 by Evan Huus (eapache@xxxxxxxxx):

    Tweak ber_choice flow control.
    
    There appear to be a couple of bugs in the flow control of this function (which
    is very confusing), at least one of which is leading to a buffer overrun. See
    the bug comments for more details and guesses of what the correct thing to do
    is.
    
    Bug:9579
    Change-Id: Ibd3077792c7689a715ea53e8bf8c7a561c67389f
    Reviewed-on: https://code.wireshark.org/review/1530
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  d3a1cde   fix dissect_usb_endpoint_descriptor
    adds  ec5ba07   Tweak ber_choice flow control.


Summary of changes:
 epan/dissectors/packet-ber.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)