Wireshark-commits: [Wireshark-commits] master 9a26416: Have macros to handle the range check and by

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2014 19:41:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a26416e3ecdd37c1cb54973ed4ee4e0f1ad0b7f
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9a26416 by Guy Harris (guy@xxxxxxxxxxxx):

      Have macros to handle the range check and byte swapping.
      
      Combine the check for whether the field is within the packet data and
      the swapping of the field into macros that do both, and use them.
      
      Change-Id: I1db4c5fd76172edd44abc9fb111d79a2537c6c9d
      Reviewed-on: https://code.wireshark.org/review/130
      Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
      Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
      

Actions performed:

      from  991bd3d   Fix bug 9732: ' Lua: recent commit changed some MENU_ key names in init.lua'
      adds  9a26416   Have macros to handle the range check and byte swapping.


Summary of changes:
 wiretap/pcap-common.c |  100 ++++++++++++++++++++++---------------------------
 1 file changed, 44 insertions(+), 56 deletions(-)