URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=991bd3d7e10966e429bebd71bd7433f61e320482
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
991bd3d by Hadriel Kaplan (hadrielk@xxxxxxxxx):
Fix bug 9732: ' Lua: recent commit changed some MENU_ key names in init.lua'
A recent fix (made by me) for bug 9707, in Change-Id:
If4ee1906aa60dd37366cf2ef9bc4168e0ea024b6, made the perl regex grab too much
of the menu name. It changed MENU_STAT_CONVERSATION, MENU_STAT_RESPONSE, and
MENU_ANALYZE_CONVERSATION's key names into their longer C-code names. Ugh.
The fix for this is a bit brittle, but I think it's impractical to avoid it
being brittle, due to needing to support legacy Lua scripts. I put comments
in stat_menu.h to warn of the danger.
Change-Id: I41408e9d4f5b5bd73e2871fccabff81c7cbd242d
Reviewed-on: https://code.wireshark.org/review/140
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 8d7b600 "origin" appears to be a safer bet than "@{upstream}".
adds 991bd3d Fix bug 9732: ' Lua: recent commit changed some MENU_ key names in init.lua'
Summary of changes:
epan/wslua/make-init-lua.pl | 6 +++++-
epan/wslua/wslua_gui.c | 6 +++++-
stat_menu.h | 13 +++++++++++++
3 files changed, 23 insertions(+), 2 deletions(-)