[bugzilla-daemon@xxxxxxxxxxxxx]

DSR Corporation changed bug 9424

What	Removed	Added
CC		dsr_support@dsr-company.com

Comment # 20 on bug 9424 from DSR Corporation

> (packet-zbee-nwk.c) - In what scenario can nwk_hints be NULL a second time? 

We don't sure that wmem_new0(wmem_file_scope(), zbee_nwk_hints_t) cannot return
NULL value.

But if wmem_new0 can't return NULL indeed, then the following lines should be
removed from the our code:

if (nwk_hints == NULL) {
    /* Allocate frame data with hints for upper layers. */
    nwk_hints = (zbee_nwk_hints_t *)g_malloc0(sizeof(zbee_nwk_hints_t));
    p_add_proto_data(wmem_file_scope(), pinfo, proto_zbee_nwk, 0, nwk_hints);
}

> Does the security key UAT really need to be duplicated in the Green Power dissector?

Yes, it does.

> Why aren't the existing security keys (from packet-zbee-security.c) just shared and the code abstracted enough to use it?

Standard APS ZigBee security dissector (packet-zbee-security.*) and the Green
Power security are the unconnected entities. They should be configured in the
different tabs of Wireshark settings dialog, should be saved in different files
in ~/.wireshark and represented in different keyrings in the Wireshark sources.
APS/NWK key cannot decrypt Green Power, and vice versa.

Moreover, they use different security algorithms (e.g., compare nonce
generation). But the common function zbee_sec_ccm_decrypt is shared in the
patch to avoid code duplication.

---

      You are receiving this mail because:

• You are watching all bug changes.