Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 28 Dec 2013 00:22:14 +0000

Comment # 19 on bug 9424 from 
Comment on attachment 12341 [details]
new Green Power patch

(packet-zbee-nwk.c) - In what scenario can nwk_hints be NULL a second time?  If
it's always populated on first visit, I don't see how retreiving it in other
iterations would ever be NULL.

Does the security key UAT really need to be duplicated in the Green Power
dissector?  Why aren't the existing security keys (from packet-zbee-security.c)
just shared and the code abstracted enough to use it?  There seems like a lot
of code duplication.

You are receiving this mail because:
  • You are watching all bug changes.