Comment # 2
on bug 9454
from Michael Mann
(In reply to comment #1)
> However may be better place
> for "ethertype_data_t" is in packet-ethertype.c instead of packet.h. A lot
> of dissectors use this model.
"ethertype_data_t" needs to be in a header file (assuming your
packet-ethertype.c wasn't a typo) and I didn't think it was worth it to create
a new header file just for this function. Since ethertype() was already
declared in packet.h, I just replaced it with the necessary structure. Had
packet-ethertype.h already existed, yes I would have placed it there.
You are receiving this mail because:
- You are watching all bug changes.