Bug ID |
9454
|
Summary |
ethertype() as dissector
|
Classification |
Unclassified
|
Product |
Wireshark
|
Version |
SVN
|
Hardware |
All
|
OS |
All
|
Status |
CONFIRMED
|
Severity |
Enhancement
|
Priority |
Low
|
Component |
Dissection engine (libwireshark)
|
Assignee |
[email protected]
|
Reporter |
[email protected]
|
Blocks |
9450
|
Attachment #12124 Flags |
review_for_checkin?
|
Created attachment 12124 [details]
ethertype function converted to dissector
Build Information:
SVN r53424
--
I think the ethertype() function should be converted into a real dissector.
The provided patch does this. The main driving force for this was my "work in
progress" new Decode As functionality that wants a dissector/subdissector table
relationship for all dissectors wanting to use Decode As functionality. The
ethertype() function provides the value to the "ethertype" subdissector table
(populating pinfo->ethertype), so I think it should be matched to a dissector.
I think the (probably small) performance hit is worth the cleaner architecture.
Unless there are dissenting opinions, I'll commit this in a day or so and
continue my work on the Decode As functionality.
You are receiving this mail because:
- You are watching all bug changes.